Remove interpolation function annotation checking and refactor - #2077
Merged
Conversation
…otations) Dynamically checking of type annotations like this is flaky due to how Python internally handles type annotations
VeckoTheGecko
changed the title
| @vector_interp_method.setter | ||
| def vector_interp_method(self, method: Callable): | ||
| self._validate_vector_interp_function(method) | ||
| _assert_same_function_signature(method, ref=ZeroInterpolator) |
Contributor
There was a problem hiding this comment.
A Vector interpolation method needs to be able to accept a VectorField in the first argument. The ZeroInterpolator expects a Field currently. I don't think this will work here.
Contributor
Author
There was a problem hiding this comment.
_assert_same_function_signature doesn't check the typing anymore during runtime due to #2076 . I don't think there is a way to reliably do this in Python - since type annotations were bolted on after the fact
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v4-devfor v4 changes)